Skip to content

fix(sqllab): fix error due to anonymous user#14390

Merged
villebro merged 1 commit intoapache:masterfrom
preset-io:villebro/fix-anonymous-user
Apr 28, 2021
Merged

fix(sqllab): fix error due to anonymous user#14390
villebro merged 1 commit intoapache:masterfrom
preset-io:villebro/fix-anonymous-user

Conversation

@villebro
Copy link
Member

@villebro villebro commented Apr 28, 2021 •
edited
Loading

SUMMARY

If a query has been executed by an undefined user or someone that no longer exists in the database, an error is displayed on the SQL Lab history page:

BEFORE

image

AFTER

image

TEST PLAN

Local testing

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 28, 2021 •
edited
Loading

Codecov Report

Merging #14390 (08a16d2) into master (fc0c115) will decrease coverage by 0.24%.
The diff coverage is 80.00%.

❗ Current head 08a16d2 differs from pull request most recent head edcc340. Consider uploading reports for the commit edcc340 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14390      +/-   ##
==========================================
- Coverage   76.78%   76.54%   -0.25%     
==========================================
  Files         955      955              
  Lines       48255    48259       +4     
  Branches     6035     6036       +1     
==========================================
- Hits        37055    36941     -114     
- Misses      11005    11123     +118     
  Partials      195      195
Flag Coverage Δ
hive ?
javascript 71.30% <80.00%> (+<0.01%) ⬆️
presto ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-frontend/src/views/CRUD/data/query/QueryList.tsx 71.69% <75.00%> (-0.15%) ⬇️
...tersConfigModal/FiltersConfigForm/ControlItems.tsx 100.00% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 70.32% <0.00%> (-17.08%) ⬇️
superset/db_engine_specs/presto.py 83.36% <0.00%> (-6.95%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.37% <0.00%> (-1.70%) ⬇️
superset/db_engine_specs/base.py 87.66% <0.00%> (-0.44%) ⬇️
superset/models/core.py 88.85% <0.00%> (-0.28%) ⬇️
superset/utils/core.py 88.62% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc0c115...edcc340. Read the comment docs.

@villebro villebro force-pushed the villebro/fix-anonymous-user branch from f9519b2 to edcc340 Compare April 28, 2021 09:37
@villebro villebro requested review from nytai and riahk April 28, 2021 11:11
michael-s-molina
michael-s-molina approved these changes Apr 28, 2021
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro
Copy link
Member Author

villebro commented Apr 28, 2021

Thanks for the review @michael-s-molina !

@villebro villebro merged commit 183b5ae into apache:master Apr 28, 2021
@villebro villebro deleted the villebro/fix-anonymous-user branch April 28, 2021 16:57
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
@villebro
fix(sqllab): fix error due to anonymous user (apache#14390)
45bdd04
@m-ajay m-ajay mentioned this pull request Jul 31, 2022
Closed
@m-ajay m-ajay mentioned this pull request May 26, 2023
Open
@m-ajay m-ajay mentioned this pull request Oct 2, 2023
Open
@m-ajay m-ajay mentioned this pull request Feb 12, 2024
Open
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
@m-ajay m-ajay mentioned this pull request Mar 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dpgaspar dpgaspar dpgaspar approved these changes

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@nytai nytai Awaiting requested review from nytai

@riahk riahk Awaiting requested review from riahk

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@villebro @dpgaspar @michael-s-molina @mistercrunch